Add support for node-redis @4 (next to @3) as well #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
STRML
reviewed
Jul 25, 2023
| @@ -33,11 +33,25 @@ class RollingLimit { | |||
| if(!/:$/.test(this.prefix)) this.prefix += ':'; | |||
| this.force = options.force ? 'true' : 'false'; | |||
| if (!this.redis.evalshaAsync) { | |||
| if (this.redis.Promise) { | |||
| if (typeof this.redis.executeScript !== 'undefined') { | |||
There was a problem hiding this comment.
Is there a different way we can check this? Seems brittle
There was a problem hiding this comment.
I haven't found something very straight forward to check, but I did find the methods to interact with LUA scripts to be changed, with the change you commented on as the difference between the two versions. I'm sure there will be other minor API changes, but I didn't find something as explicit as you'd wish.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package supported node-redis (
redis) version 3. Version 4 has some breaking changes.This PR adds support for
redis@4while staying backwards compatible with the node redis client v3 & ioredis.The redis@4 package is aliassed as
redis4and a separate test case is added.